Wasmtime GitHub notifications bot (Sep 26 2022 at 19:44): Wasmtime GitHub notifications bot (Sep 26 2022 at 19:44):github-actions[bot] commented on issue #4962:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:module", "cranelift:wasm", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Sep 26 2022 at 19:48):cfallin commented on issue #4962:
Updated RELEASES file. Waiting for a bit to see if any other fixes need to ride along with this patch release, otherwise we'll merge later today.
Wasmtime GitHub notifications bot (Sep 26 2022 at 19:51):cfallin commented on issue #4962:
r? @alexcrichton for release-notes update?
Wasmtime GitHub notifications bot (Sep 26 2022 at 20:00):bjorn3 commented on issue #4962:
No other patches necessary for cg_clif. All tests passed on AArch64 when I was working on my PR. They already passed on x86_64 (both Linux and macOS) @afonso360 said they found some regression on Windows, but that wasn't working great before Cranelift 0.88 anyway (or at all in case of MSVC, no idea if the regressions also affect MinGW. @afonso360?), so I don't mind having to wait another release personally.
Wasmtime GitHub notifications bot (Sep 26 2022 at 20:12):afonso360 commented on issue #4962:
The actual regressions were with build system stuff on cg_clif so I think we are good here. But we also have some tests failing on MinGW with windows as a host, which I think was working before but I'm not quite sure so it might not be a regression.
Wasmtime GitHub notifications bot (Sep 26 2022 at 20:13):afonso360 edited a comment on issue #4962:
The actual regressions ended up being build system stuff on cg_clif so I think we are good here. But we also have some tests failing on MinGW with windows as a host, which I think was working before but I'm not quite sure so it might not be a regression.
Wasmtime GitHub notifications bot (Sep 26 2022 at 20:28):cfallin commented on issue #4962:
Alright, after checking with folks, there's nothing else that we want to include here so I'll go ahead and merge with just this cherrypick. Thanks again for the fix!
Last updated: Dec 23 2024 at 12:05 UTC