Stream: git-wasmtime

Topic: wasmtime / issue #4961 cranelift: investigate using union...

Wasmtime GitHub notifications bot (Sep 26 2022 at 18:52):

fitzgen labeled issue #4961:

A not-insignificant portion of compilation time is spent in lowering, and when you start expanding the call tree, a lot of that time semi-surprisingly ends up being in value_def. value_def ends up doing repeated alias resolution, my theory is that we are repeatedly doing overlapping alias resolutions. We should investigate using union find to incrementally dedupe this repeated work.

Wasmtime GitHub notifications bot (Sep 26 2022 at 18:52):

fitzgen opened issue #4961:

A not-insignificant portion of compilation time is spent in lowering, and when you start expanding the call tree, a lot of that time semi-surprisingly ends up being in value_def. value_def ends up doing repeated alias resolution, my theory is that we are repeatedly doing overlapping alias resolutions. We should investigate using union find to incrementally dedupe this repeated work.

Wasmtime GitHub notifications bot (Sep 26 2022 at 19:17):

bjorn3 commented on issue #4961:

The cache for this would need to be cleared when changing the definition of any alias, right?

Last updated: Oct 23 2024 at 20:03 UTC