Stream: git-wasmtime

Topic: wasmtime / issue #4915 Flatten `and` patterns in ISLE

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2022 at 17:12):

elliottt commented on issue #4915:

This looks correct to me and should help to normalize the generated code.

Does this PR change the output for any current backend?

It doesn't appear to, as running cargo test -p cranelift-tools --tests=filetests locally reported no errors.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2022 at 17:12):

elliottt edited a comment on issue #4915:

This looks correct to me and should help to normalize the generated code.

Does this PR change the output for any current backend?

It doesn't appear to, as running cargo test -p cranelift-tools --test filetests locally reported no errors.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2022 at 17:13):

jameysharp commented on issue #4915:

It doesn't appear to, as running cargo test -p cranelift-tools --test filetests locally reported no errors.

Oh, that's good, but I meant to ask if the Rust that islec generates changed.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2022 at 17:14):

github-actions[bot] commented on issue #4915:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2022 at 17:19):

elliottt commented on issue #4915:

It doesn't appear to, as running cargo test -p cranelift-tools --test filetests locally reported no errors.

Oh, that's good, but I meant to ask if the Rust that islec generates changed.

No difference: I generated the rust output on main and this branch, and diff'd the two trees. I think this makes sense, because when we produce a list of PatternInst values before trie construction, Pattern::And nodes are inlined directly. This PR just pushes some of that inlining earlier in the pipeline.

Last updated: Oct 23 2024 at 20:03 UTC