elliottt commented on issue #4915:
This looks correct to me and should help to normalize the generated code.
Does this PR change the output for any current backend?
It doesn't appear to, as running
cargo test -p cranelift-tools --tests=filetests
locally reported no errors.
elliottt edited a comment on issue #4915:
This looks correct to me and should help to normalize the generated code.
Does this PR change the output for any current backend?
It doesn't appear to, as running
cargo test -p cranelift-tools --test filetests
locally reported no errors.
jameysharp commented on issue #4915:
It doesn't appear to, as running
cargo test -p cranelift-tools --test filetests
locally reported no errors.Oh, that's good, but I meant to ask if the Rust that islec generates changed.
github-actions[bot] commented on issue #4915:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
elliottt commented on issue #4915:
It doesn't appear to, as running
cargo test -p cranelift-tools --test filetests
locally reported no errors.Oh, that's good, but I meant to ask if the Rust that islec generates changed.
No difference: I generated the rust output on
main
and this branch, and diff'd the two trees. I think this makes sense, because when we produce a list ofPatternInst
values before trie construction,Pattern::And
nodes are inlined directly. This PR just pushes some of that inlining earlier in the pipeline.
Last updated: Dec 23 2024 at 13:07 UTC