Stream: git-wasmtime

Topic: wasmtime / issue #4914 fuzzgen: Disable verifier after Na...

Wasmtime GitHub notifications bot (Sep 15 2022 at 14:45):

github-actions[bot] commented on issue #4914:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "fuzzing"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Sep 15 2022 at 16:26):

jameysharp commented on issue #4914:

Oh, one question: is the incremental cache fuzz target also running the validator?

Wasmtime GitHub notifications bot (Sep 15 2022 at 16:41):

afonso360 commented on issue #4914:

Yes, in Context::compile_stencil.

https://github.com/bytecodealliance/wasmtime/blob/d0b98aa25f2f9dab722cc266c3bcee129b3a83ad/cranelift/codegen/src/context.rs#L132-L135

But it might also be worth forcing the enable_verifier default and putting in the comment to note that its important

Wasmtime GitHub notifications bot (Sep 15 2022 at 16:41):

afonso360 edited a comment on issue #4914:

Yes, in Context::compile_stencil.

https://github.com/bytecodealliance/wasmtime/blob/d0b98aa25f2f9dab722cc266c3bcee129b3a83ad/cranelift/codegen/src/context.rs#L132-L135

But it might also be worth forcing the enable_verifier default and putting in the comment to note that its important like we do for the cranelift-fuzzgen target

Last updated: Oct 23 2024 at 20:03 UTC