saulecabrera commented on issue #4907:
Thanks for the feedback @cfallin; I'll go through each of the review items separately; at a high-level I think that I'd like to tackle some of the refactoring items in this PR (e.g. moving winch to a top level directory and using that in
wasmtime-winch
) to have a common base moving forward, it shouldn't be too complicated and hopefully the rebasing won't be too bad either.
saulecabrera commented on issue #4907:
@cfallin I've addressed all the review items, this is ready for another pass. I decided to tackle the major refactoring items in this PR, so now the structure looks like:
winch/src/main
: the CLI tool (winch-tools
)winch/codegen
: all the code generation pieces (winch-codegen
)crates/winch
: the wasmtime integration (winch-wasmtime
)I had a brief battle with the
CI/verify-publish
job, but I think that I got the handle of the expected structure; I'd appreciate a verification there (I was thinking maybe @alexcrichton could peek and confirm too).
saulecabrera commented on issue #4907:
Hmm it seems that my change to address the comments formatting got lost. Looking into this.
saulecabrera commented on issue #4907:
Hmm it seems that my change to address the comments formatting got lost. Looking into this.
Formatting was indeed missing. It was an oversight from my end.
saulecabrera edited a comment on issue #4907:
Hmm it seems that my change to address the comment formatting got lost. Looking into this.
Last updated: Dec 23 2024 at 12:05 UTC