Stream: git-wasmtime

Topic: wasmtime / issue #4905 Leverage Cargo's workspace inherit...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 13 2022 at 16:00):

alexcrichton commented on issue #4905:

It's worth pointing out that Rust 1.64.0 is not out yet and will be released next week (I think) so this can't merge earlier than that. I've attempted to hack around that on CI by installing beta for all the builders (we'll see how that goes).

Otherwise though I wanted to go ahead and open this up to get others' thoughts on it to see if others are ok with it or feel like this isn't a great change for Wasmtime.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 13 2022 at 16:03):

abrown commented on issue #4905:

Does publish.rs need to change?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 13 2022 at 16:51):

jameysharp commented on issue #4905:

This looks helpful! I'm in favor of merging it eventually. I'd be inclined to wait for some time after the 1.64 release though: at least a week, maybe a month? For something that's only nice-to-have, I think it's worth giving people who are working in git some slack on when to upgrade their toolchain.

If this affected people who are depending on any of these crates through crates.io then I'd wait longer. But if cargo publish rewrites all of this away during the publish process, then that clearly doesn't matter.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 13 2022 at 17:22):

alexcrichton commented on issue #4905:

@abrown it will yeah, I recalled I should do that right before pushing and then forgot to note it again, thanks for the reminder!

@jameysharp our current policy is that Wasmtime can use up to the latest stable on main, and AFAIK we've never historically delayed landing something due to Rust just recently being released. I would personally like to land this sooner rather than later as it bitrots really quickly.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 13 2022 at 17:59):

github-actions[bot] commented on issue #4905:

Subscribe to Label Action

cc @cfallin, @fitzgen, @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:module", "cranelift:wasm", "isle", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2022 at 14:35):

alexcrichton commented on issue #4905:

Ok I think this should be good for a review now with 1.64.0 released.

Last updated: Oct 23 2024 at 20:03 UTC