Stream: git-wasmtime

Topic: wasmtime / issue #4810 Revert "cranelift: Register all fu...

Wasmtime GitHub notifications bot (Aug 30 2022 at 00:25):

jameysharp commented on issue #4810:

Can we just undo the addition of test interpret on filetests/filetests/runtests/call.clif? That's enough to make the tests pass for me again locally.

Wasmtime GitHub notifications bot (Aug 30 2022 at 00:32):

jameysharp edited a comment on issue #4810:

Can we just undo the addition of test interpret on filetests/filetests/runtests/call.clif? That's enough to make the tests pass for me again locally.

I'm puzzled that CI passed this PR since it must have run these tests. I assume there was some interaction between #4800 and #4782.

Wasmtime GitHub notifications bot (Aug 30 2022 at 00:51):

cfallin commented on issue #4810:

I don't mind too much either way, but for the sake of setting precedent I'd prefer to keep to the simple principle of "revert PR and get back to green CI asap". More than half of my reasoning there is just that the CI is fairly close to done here and I don't want to delay the fix further :-)

Wasmtime GitHub notifications bot (Aug 30 2022 at 00:53):

jameysharp commented on issue #4810:

Yeah, that's fair!

Last updated: Oct 23 2024 at 20:03 UTC