Stream: git-wasmtime

Topic: wasmtime / issue #4773 [fuzz] Configure the `differential...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 17:56):

abrown commented on issue #4773:

Here is an example from running the target locally:

$ ALLOWED_MODULES=-wasm-smith cargo +nightly fuzz run differentia
...
=== Execution rate (384 successes / 2000 attempted modules): 19.20% ===
        wasmi: 0.96%, spec: 8.85%, wasmtime: 83.97%, v8: 6.22%
        wasm-smith: 0.00%, single-inst: 100.00%

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 17:59):

abrown commented on issue #4773:

@jameysharp, you've had some opinions on this in the past so I tagged you for review (?): I really would have preferred to use &[&str] everywhere (in the static variables, function parameters, etc.) but once env gave me back Strings this all started sliding toward Vec<String>. This makes for some awkward match and if statements. Do you see an easy way to convert to slices and &str or even just one of those?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 19:27):

github-actions[bot] commented on issue #4773:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2022 at 22:04):

abrown commented on issue #4773:

I think you've addressed all my suggestions. Thanks! I hope you found these suggestions helpful.

Yeah, they were great!

Last updated: Nov 22 2024 at 16:03 UTC