abrown commented on issue #4773:
Here is an example from running the target locally:
$ ALLOWED_MODULES=-wasm-smith cargo +nightly fuzz run differentia ... === Execution rate (384 successes / 2000 attempted modules): 19.20% === wasmi: 0.96%, spec: 8.85%, wasmtime: 83.97%, v8: 6.22% wasm-smith: 0.00%, single-inst: 100.00%
abrown commented on issue #4773:
@jameysharp, you've had some opinions on this in the past so I tagged you for review (?): I really would have preferred to use
&[&str]
everywhere (in the static variables, function parameters, etc.) but onceenv
gave me backString
s this all started sliding towardVec<String>
. This makes for some awkwardmatch
andif
statements. Do you see an easy way to convert to slices and&str
or even just one of those?
github-actions[bot] commented on issue #4773:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
abrown commented on issue #4773:
I think you've addressed all my suggestions. Thanks! I hope you found these suggestions helpful.
Yeah, they were great!
Last updated: Dec 23 2024 at 12:05 UTC