Stream: git-wasmtime

Topic: wasmtime / issue #4752 x64: Mask shift amounts for small ...

Wasmtime GitHub notifications bot (Aug 23 2022 at 14:43):

github-actions[bot] commented on issue #4752:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Aug 23 2022 at 16:41):

afonso360 commented on issue #4752:

I think this is also going to invalidate all the issues that were reported today, since it changes the input format for the fuzzer, not sure how good OSS-Fuzz is with these situations.

Wasmtime GitHub notifications bot (Aug 23 2022 at 16:42):

afonso360 edited a comment on issue #4752:

I think this is also going to invalidate all the fuzzer issues that were reported today, since it changes the input format for the fuzzer, not sure how good OSS-Fuzz is with these situations.

Wasmtime GitHub notifications bot (Aug 23 2022 at 16:44):

jameysharp commented on issue #4752:

You're right, Afonso. Could you remove the function-generator changes from this PR for now while we sort out all those issues?

Wasmtime GitHub notifications bot (Aug 23 2022 at 17:07):

jameysharp commented on issue #4752:

The rustfmt CI failure looks like a transient network issue. Let's re-run it after the rest of the jobs complete.

Wasmtime GitHub notifications bot (Aug 24 2022 at 10:23):

afonso360 commented on issue #4752:

const_to_type_masked_imm8 was also doing the wrong thing, and is now fixed, I've also removed the special cases for rotl/rotr which were using const_to_type_masked_imm8. We now use the general case that is using put_masked_in_imm8_gpr and doing the right thing for both cases.

Wasmtime GitHub notifications bot (Aug 24 2022 at 10:24):

afonso360 edited a comment on issue #4752:

const_to_type_masked_imm8 was also doing the wrong thing, and is now fixed, I've also removed the special cases for rotl/rotr which were using const_to_type_masked_imm8.

We now use the general case that is using put_masked_in_imm8_gpr and doing the right thing for both cases.

These were the only use cases of const_to_type_masked_imm8 outside of put_masked_in_imm8_gpr

Wasmtime GitHub notifications bot (Aug 24 2022 at 10:24):

afonso360 edited a comment on issue #4752:

const_to_type_masked_imm8 was also doing the wrong thing, and is now fixed, I've also removed the special cases for rotl/rotr which were using const_to_type_masked_imm8.

We now use the general case that is using put_masked_in_imm8_gpr and doing the right thing for both cases.

These were the only uses of const_to_type_masked_imm8 outside of put_masked_in_imm8_gpr

Wasmtime GitHub notifications bot (Aug 24 2022 at 17:31):

jameysharp commented on issue #4752:

Very nice work! Good catch on noticing that const_to_type_masked_imm8 had the same bug. I'm pleased to see so many of those and instructions disappear from the filetests. And it's great to see the ISLE rules and supporting Rust get both simpler and more correct at the same time!

Last updated: Dec 23 2024 at 13:07 UTC