Stream: git-wasmtime

Topic: wasmtime / issue #4708 Refactor and optimize the flat typ...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 17:46):

jameysharp commented on issue #4708:

Why are sizes limited to u8 in "Remove duplicate flat count calculation in wasmtime"? I can understand it for flat_count since the canonical ABI defines MAX_FLAT_PARAMS = 16, although I think that's worth a comment somewhere. I'm less sold on it for FlagsSize: although 8,160 flags "ought to be good enough for anybody", is there a reason to limit it to that?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 17:55):

alexcrichton commented on issue #4708:

I wanted to reuse the flat count for the number of u32s of a flag representation, which led to that choice. The flat count has no need to be bigger than u8, but flags may be bigger than u8 if, as you mention, there's 80k+ flags. Given that wasmparser already has a hardcoded limit of 1000 flags I didn't see much need to try and improve the situation.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 23:49):

github-actions[bot] commented on issue #4708:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Nov 22 2024 at 17:03 UTC