Wasmtime GitHub notifications bot (Aug 12 2022 at 10:37): Wasmtime GitHub notifications bot (Aug 12 2022 at 10:37):uweigand commented on issue #4682:
This looks great to me -- thanks for all of the careful work here!
Thanks!
The introduction of the BE/LE variants of vector-bitcast (as per discussion in the most recent Cranelift meeting) will come later, I assume? Totally fine to follow up with it; just want to make sure I understand the plans.
Yes, I was planning to continue working on this as a follow up. Given that with this PR merged, that follow-up is no longer expected to have any impact on code generation / correctness, but is solely about cleaning up the IR, I think we can take some time to make sure we get it right.
The details will probably require a bit more discussion, e.g. the exact CLIF IR changes (names of the new instructions etc.), and possibly a transition plan: do we need to continue to support the old
raw_bitcastfor a while to avoid breaking existing users, are there any existingraw_bitcastusers that don't readily fit into the new scheme (e.g. bitcasts between types of different sizes), etc.I'll go ahead and try to investigate these issues as far as I can, and then come back with findings or a proposal for further discussion in issue #4566.
Last updated: Nov 22 2024 at 16:03 UTC