Stream: git-wasmtime

Topic: wasmtime / issue #4673 Rename `MmapVec::drain` to `split_...

Wasmtime GitHub notifications bot (Aug 10 2022 at 17:50):

github-actions[bot] commented on issue #4673:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Aug 15 2022 at 15:51):

jameysharp commented on issue #4673:

I've pushed an alternative on top of this branch, to exactly match the behavior of Vec::split_off in MmapVec. Would you review it and merge if you're happy with it?

Wasmtime GitHub notifications bot (Aug 15 2022 at 17:20):

alexcrichton commented on issue #4673:

Looks good to me!

It also looks like github is smart enough to prevent me from approving my own PR, so I'll need your stamp as well for the merge.

Last updated: Dec 23 2024 at 12:05 UTC