Stream: git-wasmtime

Topic: wasmtime / issue #4612 Update `wasi-crypto`

view this post on Zulip Wasmtime GitHub notifications bot (Aug 17 2022 at 14:09):

npmccallum commented on issue #4612:

@sunfishcode Can we get some attention on this?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2022 at 18:25):

jedisct1 commented on issue #4612:

@rjzak -- Looking good now! Thanks!

Would you mind resolving the conflict so it can be merged?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 14 2022 at 22:34):

rjzak commented on issue #4612:

@jedisct1 I'd like to resolve the conflict, but I changed the Cargo.toml file and need it to have my version, not what this thing is that Git seems to be trying to merge. How can I force it to be my version?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2022 at 14:50):

rjzak edited a comment on issue #4612:

@jedisct1 ~I'd like to resolve the conflict, but I changed the Cargo.toml file and need it to have my version, not what this thing is that Git seems to be trying to merge. How can I force it to be my version?~
Resolved!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2022 at 13:53):

rjzak commented on issue #4612:

@jedisct1 I could use some advice regarding some of the CI errors. A lot of these are not related to wasi-crypto.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2022 at 14:07):

rjzak commented on issue #4612:

I added the nightly requirement for wasmtime-wasi-crypto since wasi-crypto uses Cargo's "per-package-target" https://github.com/WebAssembly/wasi-crypto/compare/67d9821f2763f4626a97c70c411ccb92a2047712...fa309ace2bb335bb08efc724a18721e8217d5977#diff-9c249d46387da48fcc9d73b78e7a99a00bb825ae6b5fa222b60f6b27f9a4d2a0. Is this ok @sunfishcode?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2022 at 14:21):

jedisct1 commented on issue #4612:

@rjzak I don't think nightly is required (at least I hope it's not...)

However, the errors about dead code were likely due to the example main.rs file in wasi-crypto/.../bindings/rust/src.

This has been fixed upstream, so an update to a more recent commit should fix the issues we are seeing here as well.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2022 at 15:10):

rjzak commented on issue #4612:

Nightly was only needed for running the test case for Wasi-Crypto, not for compiling the Wasmtime-Wasi-Crypto module.

I'll look at updating the Wasi-Crypto submodule.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2022 at 15:18):

jedisct1 commented on issue #4612:

Yes, but the test case depends on the Rust example bindings.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2022 at 20:21):

rjzak commented on issue #4612:

I've updated the Wasi-Crypto git submodule, may I have a re-run of CI? @sunfishcode or @jedisct1
This should fix one of the CI issues about unused import.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2022 at 20:21):

rjzak edited a comment on issue #4612:

I've updated the Wasi-Crypto git submodule, may I have a re-run of CI? @sunfishcode or @jedisct1
This should fix one of the CI issues about unused import.

Edit: nevermind, CI just decided to run as soon as I made this comment?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2022 at 16:01):

rjzak commented on issue #4612:

Abandoning in favour of future PR against the main branch.

Last updated: Nov 22 2024 at 16:03 UTC