Stream: git-wasmtime

Topic: wasmtime / issue #4592 components: Deduplicate size/align...

Wasmtime GitHub notifications bot (Aug 03 2022 at 14:38):

alexcrichton labeled issue #4592:

Currently the canonical size/align calculations for types are duplicated in a number of places throughout the codebase:

• fact/signatures.rs
• component/types.rs
• component-fuzz-util/src/lib.rs

Ideally we would only define this size/alignment calculation once in the codebase so I think it's worth trying to investigate if some of these can be deduplicated. Given the relative simplicity of the calculation I don't think it's critical to deduplicate, but I'd still prefer to try.

Wasmtime GitHub notifications bot (Aug 03 2022 at 14:38):

alexcrichton opened issue #4592:

Currently the canonical size/align calculations for types are duplicated in a number of places throughout the codebase:

• fact/signatures.rs
• component/types.rs
• component-fuzz-util/src/lib.rs

Ideally we would only define this size/alignment calculation once in the codebase so I think it's worth trying to investigate if some of these can be deduplicated. Given the relative simplicity of the calculation I don't think it's critical to deduplicate, but I'd still prefer to try.

Wasmtime GitHub notifications bot (Aug 09 2022 at 19:52):

alexcrichton closed issue #4592:

Currently the canonical size/align calculations for types are duplicated in a number of places throughout the codebase:

• fact/signatures.rs
• component/types.rs
• component-fuzz-util/src/lib.rs

Ideally we would only define this size/alignment calculation once in the codebase so I think it's worth trying to investigate if some of these can be deduplicated. Given the relative simplicity of the calculation I don't think it's critical to deduplicate, but I'd still prefer to try.

Last updated: Dec 23 2024 at 13:07 UTC