Wasmtime GitHub notifications bot (Jul 29 2022 at 20:18): Wasmtime GitHub notifications bot (Jul 29 2022 at 20:18):github-actions[bot] commented on issue #4559:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jul 29 2022 at 21:17):cfallin commented on issue #4559:
Indeed, there's more we could/should do if we want to properly warn about overflows. ISLE's type system isn't quite sophisticated enough to do that at the moment though, as it doesn't actually know about the integral types at a built-in level (mostly); so for now the model is "we hold 128 bits and we pass them through". And the codegen does an explicit
1234i128 as <ty>where<ty>is the user-defined primitive type. So we at least won't lose any bits that the defined primitive types would have held. So for now, indeed, it's an improvement!
Wasmtime GitHub notifications bot (Jul 29 2022 at 21:17):cfallin commented on issue #4559:
(Pushed a few formatting changes, no substantial diff.)
Last updated: Dec 23 2024 at 12:05 UTC