Stream: git-wasmtime

Topic: wasmtime / issue #4501 Add initial support for fused adap...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2022 at 19:35):

github-actions[bot] commented on issue #4501:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2022 at 19:43):

alexcrichton commented on issue #4501:

One thing perhaps worth mentioning here as well is the rationale for the current organization. As-is this PR adds a wasmtime_environ::fact module meaning the entire adapter compiler will be located in the wasmtime-environ crate. I chose to do this for a few reasons:

While it theoretically could be split out it felt like it would drag most of the component model support in wasmtime-environ with it for little benefit. I ended up concluding that it's not worth it at this time.

Eventually I think we want to refactor the wasmtime-environ crate to better suit a "wasmtime build without Cranelift" better. Right now there's lots of translation/compiler support in wasmtime-environ that is dead code if Wasmtime can't use Cranelift. I think this would be better suited as a Cargo feature, or better yet, a separate crate. My current thinking for a hypothetical "future ideal" is:

That way we would still have all the shared type information in a crate for everyone to share but at compile time omitting Cranelift would also automatically omit all other compilation support.


Last updated: Dec 23 2024 at 12:05 UTC