bnjbvr commented on issue #4484:
To confirm, does this problem stem from the desire to enable trace logging for some modules in your program, but not the cranelift modules?
Yes indeed.
In such a situation is the logging framework's implementation of "no, don't actually emit this trace log" for the cranelift crates too expensive?
Yes, specifically we create something that we feed the
log
calls (and that's the expensive part here), but then the logger implementation decides to throw it away based on its own configuration.
cfallin commented on issue #4484:
I think it needs a rebase again now that #4553 merged; happy to merge once that is in.
cfallin edited a comment on issue #4484:
I think it needs a rebase again now that #4553 merged; happy to merge once rebased.
bnjbvr commented on issue #4484:
This now passes CI and as there wasn't any pending comment, will merge. Thanks for the review!
Last updated: Dec 23 2024 at 12:05 UTC