Stream: git-wasmtime

Topic: wasmtime / issue #4469 cranelift: Add a new, optional fla...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2022 at 22:14):

fitzgen commented on issue #4469:

@cfallin

good to merge once we have s390x supported as well

As I just said over in https://github.com/bytecodealliance/wasmtime/pull/4431#issuecomment-1189597570 I think we can actually land this PR now, since it doesn't break anything by itself, as nothing is relying on the frame pointers yet.

But we shouldn't land https://github.com/bytecodealliance/wasmtime/pull/4431 until there is s390x support for this flag, for sure, as that would break Wasmtime on s390x.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2022 at 22:23):

cfallin commented on issue #4469:

Ah, my mistake, I had misunderstood the intended order of changes; yep, r+ for merging this now. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2022 at 22:49):

github-actions[bot] commented on issue #4469:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:meta", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 11:35):

uweigand commented on issue #4469:

cc @uweigand, your help with this last bit would be very appreciated, as I'm not familiar with s390x.

Sure, I will post a follow-up PR to add s390x support as soon as this is merged.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 15:02):

fitzgen commented on issue #4469:

Sure, I will post a follow-up PR to add s390x support as soon as this is merged.

Thanks!

Last updated: Dec 23 2024 at 12:05 UTC