Wasmtime GitHub notifications bot (Jul 20 2022 at 06:50): Wasmtime GitHub notifications bot (Jul 20 2022 at 06:50):afonso360 commented on issue #4467:
If you're currently only seeing bugs in the Fma opcode, how would you feel about commenting out that opcode in this patch? Then there's no question, I'm happy to merge it immediately.
Sure, sounds good. I've commented it out and left a link on it.
Wasmtime GitHub notifications bot (Jul 20 2022 at 20:19):jameysharp commented on issue #4467:
Fantastic! We're hitting CI hard today so this probably won't get a chance for the CI checks to run for a while, but I'm setting it to auto-merge once that passes. Thanks for your efforts on this!
I think I understand why fuzzing didn't catch the misuse of
ListPool: since you created a new pool, all the values in yourValueLists had small indexes (0..3) into the pool, and it's not so surprising that those were valid indexes into the DFG's pool as well. Or something like that.
Wasmtime GitHub notifications bot (Jul 20 2022 at 21:46):alexcrichton commented on issue #4467:
Apologies for the CI breakage, but things should be fixed with a rebase.
Last updated: Nov 22 2024 at 17:03 UTC