Stream: git-wasmtime

Topic: wasmtime / issue #4337 [do not merge] custom derive for r...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 20:18):

dicej commented on issue #4337:

@alexcrichton @jameysharp @fibonacci1729 This is my first draft of an implementation of https://github.com/bytecodealliance/wasmtime/issues/4308, supporting just records so far. Please let me me know what you think of the overall approach.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 22:28):

github-actions[bot] commented on issue #4337:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 20:00):

alexcrichton commented on issue #4337:

Also for the CI error you'll need to modify this list to include the new crate before the wasmtime crate but I think that should be it.

Or well depending on what Cargo lints for you may also need to fill out some crate metadata for the Cargo.toml as well, but you can copy that from other crates like wasmtime-environ which are all internal as well.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 21:57):

dicej commented on issue #4337:

I've restructured the code a bit to reduce duplication. Please let me know if there's anything else to change (e.g. more test cases) before this would be considered merge-able.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2022 at 02:17):

dicej commented on issue #4337:

Sorry for all the commit churn. I've added the test Jamey suggested, rebased onto main, and squashed everything down to a single commit.

Last updated: Dec 23 2024 at 12:05 UTC