Wasmtime GitHub notifications bot (Jun 28 2022 at 14:58): Wasmtime GitHub notifications bot (Jun 28 2022 at 14:58):akirilov-arm commented on issue #4331:
Also, I noticed that both
breduceandireducewere defined for vectors. Let's ignore the issue of boolean vectors and just look atireduce- that operation is still problematic because of cases such as reductions fromI62X2toI8X2; on the other hand, as far as I can tell there are neither implementations nor tests of the vector variants. Should we just restrict the IR operation definitions to scalars?cc @abrown @cfallin
Wasmtime GitHub notifications bot (Jun 28 2022 at 20:22):afonso360 commented on issue #4331:
Please, add runtests for the identity mappings, e.g. ireduce from I64 to I64.
It turns out that the verifier forbids these instructions. I've removed the rules for those.
Should we just restrict the IR operation definitions to scalars?
This sounds like a good idea, I haven't seen non 128bit vectors used anywhere and from what I've seen they are pretty much guaranteed not to compile despite being technically legal.
Wasmtime GitHub notifications bot (Jun 29 2022 at 11:15):afonso360 commented on issue #4331:
CI is stuck. Closing and reopening
Wasmtime GitHub notifications bot (Jun 30 2022 at 10:54):akirilov-arm commented on issue #4331:
@afonso360 Do you mind making the change for both operations?
Last updated: Oct 23 2024 at 20:03 UTC