Wasmtime GitHub notifications bot (Jun 22 2022 at 20:44): Wasmtime GitHub notifications bot (Jun 22 2022 at 20:44):github-actions[bot] commented on issue #4297:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 23 2022 at 09:56):bjorn3 commented on issue #4297:
This is a pretty wonky and unergonomic API to work with. For now I couldn't think of a better alternative that improved on the ergonomics.
If the
TypedFunc::callAPI returns owned rather than borrowed values, it could call post-return itself, right? Another option would be to accept a closure called with the return value which transforms the return value and call post-return after calling this closure.
Wasmtime GitHub notifications bot (Jun 23 2022 at 19:36):alexcrichton commented on issue #4297:
I'm going to go ahead and merge this, but @bjorn3 if you'd like to open an issue with more details that would be appreciated. I can't envision from your comment how such an API would look and how it would be better/worse than this iteration.
Last updated: Nov 22 2024 at 16:03 UTC