Stream: git-wasmtime

Topic: wasmtime / issue #4286 Outdated comment on managing the r...

Wasmtime GitHub notifications bot (Jun 19 2022 at 01:35):

jayzhan211 opened issue #4286:

https://github.com/bytecodealliance/wasmtime/blob/337c1ca8324f9e8c7453f9bee6415310edba6202/crates/cranelift/src/lib.rs#L43-L45

There is no update stack limit func now.

It seems that the current stack size is computed directly when enter wasmtime?

https://github.com/bytecodealliance/wasmtime/blob/337c1ca8324f9e8c7453f9bee6415310edba6202/crates/wasmtime/src/func.rs#L1289-L1309

I think the comment need to be updated or deleted.

Wasmtime GitHub notifications bot (Jun 19 2022 at 01:37):

jayzhan211 edited issue #4286:

https://github.com/bytecodealliance/wasmtime/blob/337c1ca8324f9e8c7453f9bee6415310edba6202/crates/cranelift/src/lib.rs#L43-L45

There is no update stack limit func now.

It seems that the current stack size is computed directly when enter wasmtime?

https://github.com/bytecodealliance/wasmtime/blob/337c1ca8324f9e8c7453f9bee6415310edba6202/crates/wasmtime/src/func.rs#L1289-L1309

This is the PR when update_stack_limit is removed.

I think the comment need to be updated or deleted.

Wasmtime GitHub notifications bot (Jun 22 2022 at 20:01):

alexcrichton closed issue #4286:

https://github.com/bytecodealliance/wasmtime/blob/337c1ca8324f9e8c7453f9bee6415310edba6202/crates/cranelift/src/lib.rs#L43-L45

There is no update stack limit func now.

It seems that the current stack size is computed directly when enter wasmtime?

https://github.com/bytecodealliance/wasmtime/blob/337c1ca8324f9e8c7453f9bee6415310edba6202/crates/wasmtime/src/func.rs#L1289-L1309

This is the PR when update_stack_limit is removed.

I think the comment need to be updated or deleted.

Last updated: Dec 23 2024 at 13:07 UTC