abrown commented on issue #4266:
@alexcrichton, @fitzgen: I am not really sure if this is the only place where the threads flag should be enabled to start generating shared memories--is there somewhere else that this makes sense to do?
github-actions[bot] commented on issue #4266:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton commented on issue #4266:
I think you'll also need to add
cfg.wasm_threads(...)
to the actualConfig
generation. Additionally this feature may also need disabling inset_differential_config
(but could be reenabled with v8 perhaps since we don't actually use threads). Otherwise though I think this is the main location.Pending https://github.com/bytecodealliance/wasmtime/issues/4260 it might be good to run this for a bit locally to see if anything quickly pops up and/or introduce a purposeful bug/panic to make sure the fuzzer finds it at some point.
abrown commented on issue #4266:
This change is pending https://github.com/bytecodealliance/wasm-tools/pull/639 and a new version of wasm-smith on crates.io.
abrown edited a comment on issue #4266:
This change is pending https://github.com/bytecodealliance/wasm-tools/pull/639 and https://github.com/bytecodealliance/wasm-tools/pull/639 and a new version of wasm-smith on crates.io.
abrown edited a comment on issue #4266:
This change is pending https://github.com/bytecodealliance/wasm-tools/pull/639 and a new version of wasm-smith on crates.io.
Last updated: Nov 22 2024 at 17:03 UTC