Stream: git-wasmtime

Topic: wasmtime / issue #4258 wasmtime: CompilerConfig should be...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2022 at 11:49):

PureWhiteWu opened issue #4258:

See https://github.com/bytecodealliance/wasmtime/pull/4252#pullrequestreview-1001773304.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 14:10):

alexcrichton commented on issue #4258:

To elaborate a bit, the CompilerConfig internal structure in crates/wasmtime/src/config.rs I think should move to the wasmtime_environ crate at crates/environ/src/compilation.rs. The CompilerBuilder trait can be entirely removed and instead the wasmtime-cranelift crate would have a function that goes from CompilerConfig to Box<dyn Compiler>.

Last updated: Nov 22 2024 at 16:03 UTC