github-actions[bot] commented on issue #4249:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
bjorn3 commented on issue #4249:
How fast is this code? How much would the increase in compile time for this be?
cfallin commented on issue #4249:
How fast is this code? How much would the increase in compile time for this be?
I haven't measured yet but I will soon. There are some optimizations I want to do first (e.g., make the egraph-to-CLIF lowering work without rebuilding the whole function body, reusing existing
Inst
s where no node duplication occurs). The path that runs without egraph-based opts will always exist, so debug builds shouldn't be affected; and my hope is that by subsuming GVN, LICM, simple_preopt, and removing the need to run them multiple times, we might not be too much worse or maybe even close to parity when sticking to a "very basic opts" level. That said the goal here will also be to allow more configurability in that tradeoff: eventually, it would be great to have a larger body of rewrite rules, and some framework that lets us configure "fuel" for applying those rules to some configurable limit. (More on this in the RFC for sure, when it comes!)
github-actions[bot] commented on issue #4249:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
cfallin commented on issue #4249:
Superseded by #4953; closing this one!
Last updated: Nov 22 2024 at 16:03 UTC