abrown opened issue #4213:
@jedisct1, I thought it would be interesting to build in the
Note: if you want to report a security issue, please read our security policy!
Test Case
TODO: upload Wasm file here
Steps to Reproduce
- TODO: first, ...
- TODO: second, ...
- Etc...
Expected Results
TODO: What do you expect to happen?
Actual Results
TODO: What actually happens? Panic? Segfault? Incorrect result?
Versions and Environment
Wasmtime version or commit: TODO
Operating system: TODO
Architecture: TODO
Extra Info
Anything else you'd like to add?
abrown labeled issue #4213:
@jedisct1, I thought it would be interesting to build in the
Note: if you want to report a security issue, please read our security policy!
Test Case
TODO: upload Wasm file here
Steps to Reproduce
- TODO: first, ...
- TODO: second, ...
- Etc...
Expected Results
TODO: What do you expect to happen?
Actual Results
TODO: What actually happens? Panic? Segfault? Incorrect result?
Versions and Environment
Wasmtime version or commit: TODO
Operating system: TODO
Architecture: TODO
Extra Info
Anything else you'd like to add?
abrown edited issue #4213:
@jedisct1, I thought it would be interesting to build in
wasi-crypto
to the benchmarking engine used in Sightglass over in #4207. I changed thewasmtime-bench-api
default features to includewasi-crypto
, but when I did, I observed build errors on Windows related topqcrypto-internals
:https://github.com/bytecodealliance/wasmtime/runs/6700498078?check_suite_focus=true#step:12:399
Understanding that neither the
wasmtime-bench-api
crate or thewasi-crypto
feature are completely "done," this issue is not a high priority one; I did want to get your eyes on this to see if there is anything simple that can be done to fix things. In the meantime, I will leavewasi-crypto
disabled by default inwasmtime-bench-api
.
jedisct1 commented on issue #4213:
Thanks for reporting this!
I think it was fixed here, about a week after the crate published :/
So, the next release won't have that issue. As a workaround, the
wasi-crypto
hostcalls can be compiled without the default features, effectively removing thepqcrypto
dependency.
jedisct1 edited a comment on issue #4213:
Thanks for reporting this!
I think it was fixed here, about a week after the crate was published :/
So, the next release won't have that issue. As a workaround, the
wasi-crypto
hostcalls can be compiled without the default features, effectively removing thepqcrypto
dependency.
alexcrichton closed issue #4213:
@jedisct1, I thought it would be interesting to build in
wasi-crypto
to the benchmarking engine used in Sightglass over in #4207. I changed thewasmtime-bench-api
default features to includewasi-crypto
, but when I did, I observed build errors on Windows related topqcrypto-internals
:https://github.com/bytecodealliance/wasmtime/runs/6700498078?check_suite_focus=true#step:12:399
Understanding that neither the
wasmtime-bench-api
crate or thewasi-crypto
feature are completely "done," this issue is not a high priority one; I did want to get your eyes on this to see if there is anything simple that can be done to fix things. In the meantime, I will leavewasi-crypto
disabled by default inwasmtime-bench-api
.
alexcrichton commented on issue #4213:
We've since removed wasi-crypto from in-tree, so Im' going to close this.
Last updated: Nov 22 2024 at 17:03 UTC