sparker-arm commented on issue #4200:
@cfallin I've added widen and narrow support and I've maintained the existing constraint system by sinking
DynamicTypes
fromFunction
intoDataFlowGraph
. This requires the user to declare any necessary dynamic types but they don't need to be explicit about their output types.
sparker-arm commented on issue #4200:
I noticed that Type became u16 but I didn't see anything like the tricks in https://github.com/bytecodealliance/wasmtime/pull/4269
Would you mind committing those changes so I can rebase on top? I'm happy to add my optimization on top of it.
sparker-arm commented on issue #4200:
Squashed the commits and rebased with
Type
as u16. Also corrected the global legalize code and updated the 'test' that should have caught the problem.
cfallin commented on issue #4200:
I spoke to @sparker-arm and he is planning to file followup tracking issues tomorrow; for now, this is (finally) good to merge. Thanks for the patience throughout the process!
sparker-arm commented on issue #4200:
Thanks @cfallin for all your help! I've raised an issue for the next steps.
Last updated: Dec 23 2024 at 12:05 UTC