Wasmtime GitHub notifications bot (Jun 21 2022 at 09:58): Wasmtime GitHub notifications bot (Jun 21 2022 at 09:58):sparker-arm commented on issue #4200:
@cfallin I've added widen and narrow support and I've maintained the existing constraint system by sinking
DynamicTypesfromFunctionintoDataFlowGraph. This requires the user to declare any necessary dynamic types but they don't need to be explicit about their output types.
Wasmtime GitHub notifications bot (Jul 05 2022 at 12:31):sparker-arm commented on issue #4200:
I noticed that Type became u16 but I didn't see anything like the tricks in https://github.com/bytecodealliance/wasmtime/pull/4269
Would you mind committing those changes so I can rebase on top? I'm happy to add my optimization on top of it.
Wasmtime GitHub notifications bot (Jul 06 2022 at 12:22):sparker-arm commented on issue #4200:
Squashed the commits and rebased with
Typeas u16. Also corrected the global legalize code and updated the 'test' that should have caught the problem.
Wasmtime GitHub notifications bot (Jul 07 2022 at 19:54):cfallin commented on issue #4200:
I spoke to @sparker-arm and he is planning to file followup tracking issues tomorrow; for now, this is (finally) good to merge. Thanks for the patience throughout the process!
Wasmtime GitHub notifications bot (Jul 08 2022 at 13:27):sparker-arm commented on issue #4200:
Thanks @cfallin for all your help! I've raised an issue for the next steps.
Last updated: Oct 23 2024 at 20:03 UTC