Stream: git-wasmtime

Topic: wasmtime / issue #4195 CFI improvements to the AArch64 fi...


view this post on Zulip Wasmtime GitHub notifications bot (May 31 2022 at 15:43):

cfallin commented on issue #4195:

To confirm, have you had the chance to test this on macOS arm hardware as well? If not I'm sure @cfallin would be able to test this out.

I can confirm that ./ci/run-tests.sh passes successfully on my M1 system.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2022 at 16:31):

akirilov-arm commented on issue #4195:

Thanks for testing my changes, @cfallin! Otherwise my main testing platform is an AWS Graviton3 instance that supports pointer authentication natively and that runs Ubuntu 20.04.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2022 at 21:21):

alexcrichton commented on issue #4195:

Hm CI timed out here for qemu emulation of AArch64 which we haven't seen before AFAIK, so that may actually be related to the changes here as well?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2022 at 13:22):

akirilov-arm commented on issue #4195:

@alexcrichton I have tried to elaborate on the most important technical details in the comments - please, let me know if you feel that there is anything else that warrants further explanation. Also, now this PR fixes #4226 and, finally, I have added a fix for a minor issue that I have noticed previously - I have changed the locations of the saved FP and LR registers on the fiber stack to improve compliance with the procedure call standard.


Last updated: Oct 23 2024 at 20:03 UTC