Stream: git-wasmtime

Topic: wasmtime / issue #4143 Cranelift: do not check in generat...

Wasmtime GitHub notifications bot (May 12 2022 at 00:25):

github-actions[bot] commented on issue #4143:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:x64", "cranelift:meta", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (May 12 2022 at 05:24):

cfallin commented on issue #4143:

Thanks! Updated and fixed the deterministic-meta test (previously was skipping ISLE build entirely, now does so again); will merge with your r+.

Wasmtime GitHub notifications bot (May 12 2022 at 15:26):

bjorn3 commented on issue #4143:

For me cranelift-isle takes 10s to build. The full cargo check -p cranelift-codegen takes 25s. cargo build -p cranelift-codegen takes 35s and cargo build -p cranelift-codegen --release takes 50s. So it is not ideal, but not the biggest problem either. I will see if there are some easy wins to have.

Wasmtime GitHub notifications bot (May 12 2022 at 18:51):

fitzgen commented on issue #4143:

With a default configuration, an ISLE error looks like this during build:

```
--- stderr
Error building ISLE files: ISLE errors:

parse error: Unexpected token Symbol("asdf")

To see a more detailed error report, run:

  $ cargo check -p cranelift-codegen --features isle-errors

```

Any chance we could still have a source position in there when the isle-errors feature is not enabled?

Wasmtime GitHub notifications bot (May 12 2022 at 19:12):

cfallin commented on issue #4143:

Any chance we could still have a source position in there when the isle-errors feature is not enabled?

Sure! #4151

Last updated: Dec 23 2024 at 12:05 UTC