Wasmtime GitHub notifications bot (May 11 2022 at 18:49): Wasmtime GitHub notifications bot (May 11 2022 at 18:49):cfallin opened issue #4142:
We currently have some runtests that skip some platforms (x64, aarch64, or s390x) due to unsupported lowerings. In general, we should support the same set of features everywhere. To the extent that we already have runtests for various corners of CLIF, we should look at each runtest and, where a platform is not included, work out why (missing lowerings or something else) and fix it.
(From discussion on #4139.)
Wasmtime GitHub notifications bot (May 11 2022 at 18:49):cfallin labeled issue #4142:
We currently have some runtests that skip some platforms (x64, aarch64, or s390x) due to unsupported lowerings. In general, we should support the same set of features everywhere. To the extent that we already have runtests for various corners of CLIF, we should look at each runtest and, where a platform is not included, work out why (missing lowerings or something else) and fix it.
(From discussion on #4139.)
Wasmtime GitHub notifications bot (May 11 2022 at 19:04):alexcrichton commented on issue #4142:
One thing I've seen projects do in the past for something like this is to actually assert the test fails. For example if a test isn't run on s390x we could run it automatically and assert that "this isn't implemented" pops out or something like that. If a different error pops out then we could fail the test automatically indicating that the test should be runnable on s390x (or similar)
Last updated: Nov 22 2024 at 17:03 UTC