Wasmtime GitHub notifications bot (May 11 2022 at 00:30): Wasmtime GitHub notifications bot (May 11 2022 at 00:30):cfallin opened issue #4136:
While discussing the ISLE compiler and the backend-verification project with @avanhatt and others today, the point arose that we don't actually have functional tests for ISLE in isolation; rather, Cranelift itself is our "testsuite". We do test that the ISLE compiler accepts some "good" inputs, rejects some "bad" inputs, and produces buildable and linkable Rust code for other inputs, but we never run that code with test values.
We should add tests that check various basic aspects of functionality, like rule prioritization, invocation of chains of rules, correct pattern-matching and destructuring, and the like. This will be especially useful if/when we improve the ISLE compiler with more advanced optimizations, like inlining, trie reordering, or the like.
Wasmtime GitHub notifications bot (May 11 2022 at 00:30):cfallin labeled issue #4136:
While discussing the ISLE compiler and the backend-verification project with @avanhatt and others today, the point arose that we don't actually have functional tests for ISLE in isolation; rather, Cranelift itself is our "testsuite". We do test that the ISLE compiler accepts some "good" inputs, rejects some "bad" inputs, and produces buildable and linkable Rust code for other inputs, but we never run that code with test values.
We should add tests that check various basic aspects of functionality, like rule prioritization, invocation of chains of rules, correct pattern-matching and destructuring, and the like. This will be especially useful if/when we improve the ISLE compiler with more advanced optimizations, like inlining, trie reordering, or the like.
Wasmtime GitHub notifications bot (May 11 2022 at 00:31):github-actions[bot] commented on issue #4136:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Nov 22 2024 at 16:03 UTC