alexcrichton commented on issue #4105:
Using the
Interrupt
trap code here seems reasonable to me, but instead of discarding the trap that's returned could the insertion and customization of theTrapCode
be done when the trap is first created? (e.g. in thenew_epoch
handler withinwasmtime
)
saulecabrera commented on issue #4105:
Thanks for the feedback @alexcrichton! I agree, that's a much cleaner solution, I had overlooked this approach due a misunderstanding in the relationship between
anyhow::Error
andwasmtime::Trap
.
github-actions[bot] commented on issue #4105:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Dec 23 2024 at 13:07 UTC