Stream: git-wasmtime

Topic: wasmtime / issue #3993 x64: port `load` to ISLE


view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2022 at 22:00):

github-actions[bot] commented on issue #3993:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2022 at 16:04):

abrown commented on issue #3993:

@cfallin: any thoughts on the current test failures? They are all spec tests that should trap but now don't. I'm planning to compare codegen for these tests before and after the changes but I was wondering if this sounded familiar to you before I do that.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2022 at 17:14):

cfallin commented on issue #3993:

Hmm, it's possible that the wraparound/overflow semantics with offsets changing could cause some spec tests to fail -- I think reducing to the assertion(s) that fail then comparing codegen is a good approach...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2022 at 23:14):

abrown commented on issue #3993:

it's possible that the wraparound/overflow semantics with offsets changing could cause some spec tests to fail

Yeah, I just needed to be more careful there; the original code is checking multiple things about the offset.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 08 2022 at 01:31):

abrown commented on issue #3993:

I ran cargo +nightly fuzz run differential_spec for this long:

=== Execution rate (238915 executed modules / 575000 tried modules): 41.5504347826087% ===


Last updated: Dec 23 2024 at 13:07 UTC