Wasmtime GitHub notifications bot (Mar 10 2022 at 18:45): Wasmtime GitHub notifications bot (Mar 10 2022 at 18:45):npmccallum commented on issue #3915:
This PR is a backport to the stable release of the (already merged) #3913. This bug currently causes our custom WasiFile objects to be non-pollable and is blocking the release of Enarx. We are asking for a point release containing this fix.
cc @pchickey
Wasmtime GitHub notifications bot (Mar 10 2022 at 18:57):github-actions[bot] commented on issue #3915:
Subscribe to Label Action
cc @kubkon
<details>
This issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
- kubkon: wasi
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 10 2022 at 19:17):alexcrichton commented on issue #3915:
At this time I believe we have only clearly stated that patch releases are always done for security-related fixes, but I don't believe we have any prior consenus on when or when not to do a patch release for feature-based changes like this. In that sense I don't think there's a clear answer whether we should make a point release for this or not.
I'm not certain this is the best place to discuss policy, but at least for me personally I do not think that this warrants a patch release. We intentionally chose a pretty rapid release schedule to avoid crunches around releases like this. I would not have personally wanted to make a patch release for https://github.com/bytecodealliance/wasmtime/pull/3906 either, but I wasn't the one driving the process and I'm not going to stop someone else.
That's all to say that if the decision comes down to me personally my stance is that we shouldn't do this unless there's a clear policy saying we should do this. If someone else wants to take this up and manage it though I won't stop them.
Wasmtime GitHub notifications bot (Mar 11 2022 at 12:41):npmccallum commented on issue #3915:
From my perspective, this isn't a new feature but a bug fix. Wasmtime already has support for supplying your own file types. It is just broken when you try to poll on them.
Wasmtime GitHub notifications bot (Mar 17 2022 at 18:15):alexcrichton commented on issue #3915:
I created https://github.com/bytecodealliance/wasmtime/pull/3940 coming out of discussion from today's Wasmtime meeting. It's not 100% final though, so feedback would be appreciated!
Wasmtime GitHub notifications bot (Mar 17 2022 at 19:16):npmccallum commented on issue #3915:
We have worked around the issue for now. Thanks!
Last updated: Oct 23 2024 at 20:03 UTC