Stream: git-wasmtime

Topic: wasmtime / issue #3886 x64: port `icmp` to ISLE

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2022 at 00:23):

abrown commented on issue #3886:

@cfallin or @fitzgen: trying to port these instructions over is painful. I'm stuck on how to best lower this CMP + SETcc + SETcc sequence which involves new ways to produce and consume flags. That is what remains of the i128 lowering; the vector lowering should not be difficult.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2022 at 00:41):

github-actions[bot] commented on issue #3886:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2022 at 18:18):

fitzgen commented on issue #3886:

which involves new ways to produce and consume flags

Can this not use ProducesFlagsSideEffect and ConsumesFlagsTwiceReturnsValueRegs? The value regs will be invalid, but I think that should be fine.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2022 at 14:19):

alexcrichton commented on issue #3886:

I haven't looked much into the cause, but fuzzers over the weekend found this bug in this PR -- https://github.com/bytecodealliance/wasmtime/issues/3951

Last updated: Oct 23 2024 at 20:03 UTC