Stream: git-wasmtime

Topic: wasmtime / issue #3885 Release Wasmtime 0.35.0

Wasmtime GitHub notifications bot (Mar 05 2022 at 00:41):

github-actions[bot] commented on issue #3885:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:module", "cranelift:wasm", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 05 2022 at 14:38):

bjorn3 commented on issue #3885:

No regressions on cg_clif's side. Just needs a small patch to adapt for an api change:

diff --git a/src/lib.rs b/src/lib.rs
index cb18f42f..21939cde 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -301,7 +301,10 @@ fn build_isa(sess: &Session, backend_config: &BackendConfig) -> Box<dyn isa::Tar
         }
     };

-    isa_builder.finish(flags)
+    match isa_builder.finish(flags) {
+        Ok(target_isa) => target_isa,
+        Err(err) => sess.fatal(&format!("failed to build TargetIsa: {}", err)),
+    }
 }

 /// This is the entrypoint for a hot plugged rustc_codegen_cranelift

Wasmtime GitHub notifications bot (Mar 07 2022 at 16:42):

alexcrichton commented on issue #3885:

I've put the release notes at https://github.com/bytecodealliance/wasmtime/pull/3891 for review, and otherwise unless there's any objection I'll merge this later today.

Wasmtime GitHub notifications bot (Mar 07 2022 at 17:36):

cfallin commented on issue #3885:

Good to release from my point of view!

Last updated: Dec 23 2024 at 12:05 UTC