Stream: git-wasmtime

Topic: wasmtime / issue #3816 Cranelift: ensure ISA level needed...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 21:11):

github-actions[bot] commented on issue #3816:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:x64", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 21:55):

cfallin commented on issue #3816:

Pushed updates to propagate through the rest (I only cargo check'd cranelift-codegen and wasmtime-cli before original push) and it seems that Engine::default() is actually giving an Engine without the right CPU flags to allow for SIMD; this is somewhat perplexing and I'll look into it further.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 00:03):

cfallin commented on issue #3816:

Yeah, this makes sense to me. @cfallin, don't know if I understand your last comment: does your latest commit fix the issue or are more changes required?

Yes, it just needed one more tweak (pushed now) -- namely to set SSE3, SSSE3, SSE4.1 on by default for a Flags that is constructed manually (vs. from cranelift_native); otherwise a wasmtime compile fails because SIMD is on by default, and the CLI machinery sets an explicit target which establishes default feature flags.


Last updated: Dec 23 2024 at 13:07 UTC