github-actions[bot] commented on issue #3816:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:x64", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
cfallin commented on issue #3816:
Pushed updates to propagate through the rest (I only cargo check'd cranelift-codegen and wasmtime-cli before original push) and it seems that
Engine::default()
is actually giving an Engine without the right CPU flags to allow for SIMD; this is somewhat perplexing and I'll look into it further.
cfallin commented on issue #3816:
Yeah, this makes sense to me. @cfallin, don't know if I understand your last comment: does your latest commit fix the issue or are more changes required?
Yes, it just needed one more tweak (pushed now) -- namely to set SSE3, SSSE3, SSE4.1 on by default for a
Flags
that is constructed manually (vs. fromcranelift_native
); otherwise awasmtime compile
fails because SIMD is on by default, and the CLI machinery sets an explicit target which establishes default feature flags.
Last updated: Nov 22 2024 at 16:03 UTC