Stream: git-wasmtime

Topic: wasmtime / issue #3802 [AArch64] Merge 32- and 64-bit ALUOps

Wasmtime GitHub notifications bot (Feb 17 2022 at 11:53):

sparker-arm commented on issue #3802:

Hi @cfallin

One thing to double-check before merging: can we verify that the size of Inst remains the same, even with the extra OperandSize?

There's a test in the aarch64 backend:

#[test]
fn inst_size_test() {
    // This test will help with unintentionally growing the size
    // of the Inst enum.
    assert_eq!(32, std::mem::size_of::<Inst>());
}

Is this enough is this is passing?

Wasmtime GitHub notifications bot (Feb 17 2022 at 11:54):

sparker-arm edited a comment on issue #3802:

Hi @cfallin

One thing to double-check before merging: can we verify that the size of Inst remains the same, even with the extra OperandSize?

There's a test in the aarch64 backend:

#[test]
fn inst_size_test() {
    // This test will help with unintentionally growing the size
    // of the Inst enum.
    assert_eq!(32, std::mem::size_of::<Inst>());
}

Is this enough if this is passing?

Last updated: Oct 23 2024 at 20:03 UTC