Stream: git-wasmtime

Topic: wasmtime / issue #3792 Added 'add_fuel' command line option

Wasmtime GitHub notifications bot (Feb 11 2022 at 18:07):

fitzgen commented on issue #3792:

You don't need to modify the clif interpreter at all here.

You want to add a call to https://docs.rs/wasmtime/latest/wasmtime/struct.Store.html#method.add_fuel somewhere around here: https://github.com/bytecodealliance/wasmtime/blob/main/src/commands/run.rs#L165

Wasmtime GitHub notifications bot (Feb 11 2022 at 20:00):

ilikepi63 commented on issue #3792:

@fitzgen Thank you so much! That specific instantiation eluded me!

Thank you so much for being so patient and understanding, as well as holding my hand through this!

Wasmtime GitHub notifications bot (Feb 15 2022 at 06:06):

ilikepi63 commented on issue #3792:

The only concern I could see from --fuel is the point where someone could call without --add-fuel to indicate that they want to '--consume-fuel' with 0 fuel.

I am not sure if there is a use case, but just thought I would mention it.

Wasmtime GitHub notifications bot (Feb 15 2022 at 06:07):

ilikepi63 edited a comment on issue #3792:

The only concern I could see from --fuel is the point where someone could call without --add-fuel to indicate that they want to --consume-fuel with 0 fuel.

I am not sure if there is a use case, but just thought I would mention it.

Wasmtime GitHub notifications bot (Feb 15 2022 at 17:24):

fitzgen commented on issue #3792:

The only concern I could see from --fuel is the point where someone could call without --add-fuel to indicate that they want to --consume-fuel with 0 fuel.

In that case they would be able to do --fuel 0.

Wasmtime GitHub notifications bot (Feb 15 2022 at 17:29):

fitzgen commented on issue #3792:

Once you commit these suggestions, I'll hit the merge button.

Or I guess github lets me add those suggestions as commits to your branch :)

Wasmtime GitHub notifications bot (Feb 15 2022 at 17:55):

ilikepi63 commented on issue #3792:

Thanks @fitzgen!

Learnt a lot from this. Eager to try some more once I get a better understanding of compiler architecture. Thanks again for all the input, you are the best!

Last updated: Nov 22 2024 at 16:03 UTC