Wasmtime GitHub notifications bot (Feb 05 2022 at 00:28): Wasmtime GitHub notifications bot (Feb 05 2022 at 00:28):github-actions[bot] commented on issue #3768:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:module", "cranelift:wasm", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 07 2022 at 15:19):alexcrichton commented on issue #3768:
@fitzgen IIRC there was an x86_64 issue you wanted to see fixed before this merged, is that still the case, and if so can you link it here?
Wasmtime GitHub notifications bot (Feb 07 2022 at 15:51):cfallin commented on issue #3768:
FWIW I think that we should probably get #3769 in (or some equivalent fix) before release -- otherwise the user can hit a panic if building with debuginfo and using cold blocks.
Wasmtime GitHub notifications bot (Feb 07 2022 at 16:16):alexcrichton commented on issue #3768:
I've added release notes here as well if someone wouldn't mind giving it a once-over as well
Wasmtime GitHub notifications bot (Feb 07 2022 at 17:27):cfallin edited a comment on issue #3768:
<strike>FWIW I think that we should probably get #3769 in (or some equivalent fix) before release -- otherwise the user can hit a panic if building with debuginfo and using cold blocks.</strike> _(now merged)_
Wasmtime GitHub notifications bot (Feb 07 2022 at 17:41):fitzgen commented on issue #3768:
@fitzgen IIRC there was an x86_64 issue you wanted to see fixed before this merged, is that still the case, and if so can you link it here?
No issue on file yet. I need to check that the trap lowerings that have been ported to ISLE on x64 either don't need safepoints or implement safepoints on x64 for them if they do need them.
Wasmtime GitHub notifications bot (Feb 07 2022 at 18:26):fitzgen commented on issue #3768:
@fitzgen IIRC there was an x86_64 issue you wanted to see fixed before this merged, is that still the case, and if so can you link it here?
No issue on file yet. I need to check that the trap lowerings that have been ported to ISLE on x64 either don't need safepoints or implement safepoints on x64 for them if they do need them.
Last updated: Nov 22 2024 at 16:03 UTC