Stream: git-wasmtime

Topic: wasmtime / issue #3761 cranelift-isle crate is missing th...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 03 2022 at 16:09):

decathorpe opened issue #3761:

It looks like the cranelift-isle is missing a LICENSE file (or symlink). Since all other crates I see in this repository contain a LICENSE file or symlink, this seems to have been a simple oversight when creating the cranelift-isle crate a few months ago.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 03 2022 at 17:56):

cfallin commented on issue #3761:

Thanks for noticing this!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 03 2022 at 18:39):

cfallin closed issue #3761:

It looks like the cranelift-isle is missing a LICENSE file (or symlink). Since all other crates I see in this repository contain a LICENSE file or symlink, this seems to have been a simple oversight when creating the cranelift-isle crate a few months ago.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 10:31):

decathorpe commented on issue #3761:

It now looks like the cranelift-isle crate was split into multiple crates, and the LICENSE file was not moved / copied accordingly :(

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 19:04):

cfallin commented on issue #3761:

Sorry about that! I'll fix it, and see about adding a check to our CI to ensure we don't break this again.


Last updated: Dec 23 2024 at 12:05 UTC