Stream: git-wasmtime

Topic: wasmtime / issue #3749 Wrong externref_returns_count for ...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 17:39):

biuld opened issue #3749:

<img width="958" alt="截屏2022-02-02 上午1 35 11" src="https://user-images.githubusercontent.com/36144654/152020679-a7afd996-48be-4ccb-8a6d-c454a4338b67.png">
Just studying the source code and I found this. Is that externref_returns_count should be obtained from returns instead of params?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 18:29):

fitzgen closed issue #3749:

<img width="958" alt="截屏2022-02-02 上午1 35 11" src="https://user-images.githubusercontent.com/36144654/152020679-a7afd996-48be-4ccb-8a6d-c454a4338b67.png">
Just studying the source code and I found this. Is that externref_returns_count should be obtained from returns instead of params?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 20:58):

pchickey commented on issue #3749:

Great job spotting this bug, thanks for the report! This was a correctness issue, but we don't believe that its a security-critical bug since, internally, the only effect this could have is letting wasmtime miss an opportunity to gc.


Last updated: Oct 23 2024 at 20:03 UTC