Stream: git-wasmtime

Topic: wasmtime / issue #3728 ISLE: support primitive type defin...

Wasmtime GitHub notifications bot (Jan 27 2022 at 00:58):

fitzgen labeled issue #3728:

Right now:

(type <MyIsleType> (primitive <MyRustType>))

If MyIsleType == MyRustType then we should support just doing:

(type MyType (primitive))

I just spent too much time debugging ISLE generating the "wrong" type when I copy-pasted a primitive type definition and changed the ISLE name without also changing the name inside (primitive ...). This short-hand syntax, which is what I want 100% of the time thus far, would have prevented this bug from occurring.

Wasmtime GitHub notifications bot (Jan 27 2022 at 00:58):

fitzgen opened issue #3728:

Right now:

(type <MyIsleType> (primitive <MyRustType>))

If MyIsleType == MyRustType then we should support just doing:

(type MyType (primitive))

I just spent too much time debugging ISLE generating the "wrong" type when I copy-pasted a primitive type definition and changed the ISLE name without also changing the name inside (primitive ...). This short-hand syntax, which is what I want 100% of the time thus far, would have prevented this bug from occurring.

Wasmtime GitHub notifications bot (Jan 27 2022 at 00:58):

github-actions[bot] commented on issue #3728:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (May 04 2022 at 20:02):

cfallin labeled issue #3728:

Right now:

(type <MyIsleType> (primitive <MyRustType>))

If MyIsleType == MyRustType then we should support just doing:

(type MyType (primitive))

I just spent too much time debugging ISLE generating the "wrong" type when I copy-pasted a primitive type definition and changed the ISLE name without also changing the name inside (primitive ...). This short-hand syntax, which is what I want 100% of the time thus far, would have prevented this bug from occurring.

Last updated: Dec 23 2024 at 12:05 UTC