Stream: git-wasmtime

Topic: wasmtime / issue #3711 Implement `sock_accept` and basic ...

Wasmtime GitHub notifications bot (Jan 27 2022 at 12:01):

haraldh commented on issue #3711:

@npmccallum now it's ready for a review :)

Wasmtime GitHub notifications bot (Jan 28 2022 at 12:44):

haraldh commented on issue #3711:

Changed one more thing:

             async fn get_fdflags(&self) -> Result<FdFlags, Error> {
-                Err(Error::badf())
+                let fdflags = self.0.as_filelike().get_fd_flags()?;
+                Ok(from_sysif_fdflags(fdflags))
             }

Wasmtime GitHub notifications bot (Jan 28 2022 at 12:44):

haraldh edited a comment on issue #3711:

Changed one more thing to make fd_fdstat_get() work on the sockets.

             async fn get_fdflags(&self) -> Result<FdFlags, Error> {
-                Err(Error::badf())
+                let fdflags = self.0.as_filelike().get_fd_flags()?;
+                Ok(from_sysif_fdflags(fdflags))
             }

Wasmtime GitHub notifications bot (Jan 31 2022 at 13:08):

haraldh commented on issue #3711:

All right.. rust-lang PR merged :partying_face:

Wasmtime GitHub notifications bot (Jan 31 2022 at 15:08):

npmccallum commented on issue #3711:

@sunfishcode Is this ready for merge?

Wasmtime GitHub notifications bot (Feb 01 2022 at 00:25):

sunfishcode commented on issue #3711:

Yes, looks good to me!

Last updated: Nov 22 2024 at 17:03 UTC