Stream: git-wasmtime

Topic: wasmtime / issue #3699 Add epoch-based interruption for c...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 19 2022 at 02:15):

github-actions[bot] commented on issue #3699:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jan 19 2022 at 14:15):

bjorn3 commented on issue #3699:

I think there is value in having this exist in addition to the fuel mechanism rather than as replacement. There are cases where determinism is essential, whether for reproducibility or to implement an rr like debugger. In other cases performance is indeed more important. In those cases the epoch-based interruption can be used.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 19 2022 at 18:02):

cfallin commented on issue #3699:

I think there is value in having this exist in addition to the fuel mechanism rather than as replacement. There are cases where determinism is essential, whether for reproducibility or to implement an rr like debugger. In other cases performance is indeed more important. In those cases the epoch-based interruption can be used.

@bjorn3 yes, indeed, I guess I was thinking "replace many uses of fuel" rather than "actually remove fuel", but that was ambiguous, sorry. I agree that determinism is very useful in other circumstances and so we probably don't want to actually remove fuel; this PR keeps it around and perhaps I can add some documentation on the tradeoff and when to use each.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 20 2022 at 03:14):

cfallin commented on issue #3699:

@alexcrichton I think I've addressed most of your comments; thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 20 2022 at 21:44):

cfallin commented on issue #3699:

Updated and added an example -- will resolve the doc-comment broken links then merge, if all's well otherwise. Thanks!

Last updated: Dec 23 2024 at 12:05 UTC