Stream: git-wasmtime

Topic: wasmtime / issue #3666 Remove unnecessary into_iter/collect

view this post on Zulip Wasmtime GitHub notifications bot (Jan 07 2022 at 20:04):

nankeen opened issue #3666:

Improvement

This is just a small refactor but submitting this as a formality. I believe flags and isa_flags were already of the correct type here. So it seems unnecessary to collect it into a BTreeMap.

https://github.com/bytecodealliance/wasmtime/blob/ab5aea7b28c9c4c6cf7f52b3d8c249992a1bd26f/crates/wasmtime/src/module.rs#L953

Suggestion

Remove into_iter/collect.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2022 at 16:31):

nankeen closed issue #3666:

Improvement

This is just a small refactor but submitting this as a formality. I believe flags and isa_flags were already of the correct type here. So it seems unnecessary to collect it into a BTreeMap.

https://github.com/bytecodealliance/wasmtime/blob/ab5aea7b28c9c4c6cf7f52b3d8c249992a1bd26f/crates/wasmtime/src/module.rs#L953

Suggestion

Remove into_iter/collect.

Last updated: Oct 23 2024 at 20:03 UTC