Wasmtime GitHub notifications bot (Dec 17 2021 at 19:45): Wasmtime GitHub notifications bot (Dec 17 2021 at 19:45):cfallin commented on issue #3617:
Thanks! Can you add some run-tests too?
Wasmtime GitHub notifications bot (Dec 17 2021 at 19:59):bjorn3 commented on issue #3617:
Done. Also made the existing aarch64 popcnt tests run on x86_64.
Wasmtime GitHub notifications bot (Dec 17 2021 at 20:07):bjorn3 commented on issue #3617:
Would it be possible to get a patch release with https://github.com/bytecodealliance/wasmtime/pull/3610, this PR and maybe https://github.com/bytecodealliance/wasmtime/pull/3619? #3610 and this PR fix a miscompilation and I switched cg_clif back to crates.io releases after feedback from my PR to distribute cg_clif as rustup component on nightly.
Wasmtime GitHub notifications bot (Dec 17 2021 at 20:27):cfallin commented on issue #3617:
Would it be possible to get a patch release
Yes, I think actual miscompilation merits this (for clarity to others, Wasm is not affected, just 8/16-bit types). I'll give our new semi-automated patch release process a try; right now this implies a patch release of Wasmtime as well, which will be a no-op, and we need a better story for just patching Cranelift in the future, but this will do. If there's some unexpected issue and I can't get it out in reasonable time today then the next major release on Jan 5 will include all the changes.
Last updated: Nov 22 2024 at 17:03 UTC