Stream: git-wasmtime

Topic: wasmtime / issue #3616 Cranelift ISLE build script: make ...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 17 2021 at 19:11):

cfallin commented on issue #3616:

Urgh, I forgot the one change in Cargo.toml that actually makes sha2 optional; fix coming momentarily!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 17 2021 at 19:26):

alexcrichton commented on issue #3616:

If sha2 is uncomfortable enough to have a PR to implement this then it seems like we would want to disable this feature in the Wasmtime embedding, but that would then basically subvert the purpose of adding this check in the first place. If we take this even further than the feature here should be on-by-default for development but off-by-default for crates.io publications in the limit.

Overall I feel like we either need to find a slimmer crate so that it doesn't matter or we need to consider these concerns for Wasmtime as well. Personally I'd be fine just using std::hash::SipHasher since it's at least built-in to std and despite being deprecated it won't ever be removed.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 17 2021 at 20:02):

cfallin commented on issue #3616:

That's a good point! I took the SipHash approach instead in #3619; closing this PR.

Last updated: Dec 23 2024 at 12:05 UTC