Stream: git-wasmtime

Topic: wasmtime / issue #3599 wasmtime-cache: file-per-thread-lo...

Wasmtime GitHub notifications bot (Dec 14 2021 at 11:59):

theduke opened issue #3599:

Feature

Make file-per-thread-logger an optional dependency for wasmtime-cache.

Benefit

wasmtime-cache pulls in file-per-thread-logger, which also brings termcolor, regex, and atty, even if you don't want to have those logs.

In addition: glancing at the code it seems like the logging feature is actually never used, because Worker::start_new is always called with None as the log prefix.

Is this some left-over code?

Wasmtime GitHub notifications bot (Dec 14 2021 at 12:00):

theduke edited issue #3599:

Feature

Make file-per-thread-logger an optional dependency for wasmtime-cache.

Benefit

wasmtime-cache pulls in file-per-thread-logger, which also brings termcolor, regex, and atty, even if you don't want to have those logs.

This is especially relevant because cache is a default feature of wasmtime.

In addition: glancing at the code it seems like the logging feature is actually never used, because Worker::start_new is always called with None as the log prefix.

Is this some left-over code?

Wasmtime GitHub notifications bot (Dec 14 2021 at 12:01):

theduke edited issue #3599:

Feature

Make file-per-thread-logger an optional dependency for wasmtime-cache.

Benefit

wasmtime-cache pulls in file-per-thread-logger, which also brings termcolor, regex, and atty, even if you don't want to have those logs.

This is especially relevant because cache is a default feature of wasmtime.

In addition: glancing at the code it seems like the logging feature is actually never used - Worker::start_new is always called with None as the log prefix.

Is this some left-over code?

Wasmtime GitHub notifications bot (Dec 14 2021 at 12:07):

theduke commented on issue #3599:

I'm happy to do a PR that just removed the logger completely.
Users that want logging can wire up log as they see fit.

Last updated: Nov 22 2024 at 16:03 UTC